Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider user agent to on-ramp Checkout WebView #4818

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Add provider user agent to on-ramp Checkout WebView #4818

merged 2 commits into from
Aug 8, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Aug 8, 2022

Description

This PR adds a custom user-agent to the WebView when the provider has provided a value.

@wachunei wachunei marked this pull request as ready for review August 8, 2022 18:52
@wachunei wachunei requested a review from a team as a code owner August 8, 2022 18:52
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.6.0 PRs for v5.6.0 release labels Aug 8, 2022
alaahd
alaahd approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wachunei wachunei mentioned this pull request Aug 8, 2022
Closed
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 8, 2022
Cal-L
Cal-L approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit 5406cf5 into main Aug 8, 2022
@wachunei wachunei deleted the feature/onramp-provider-ua branch August 8, 2022 21:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.6.0 PRs for v5.6.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @alaahd @Cal-L