Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staging env redirection url for onramp #4821

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix staging env redirection url for onramp #4821

merged 1 commit into from
Aug 9, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Aug 9, 2022

Description

This PR fixes the URL we use in staging environment for redirection after purchase

@wachunei wachunei requested a review from a team as a code owner August 9, 2022 13:56
@wachunei wachunei added team-ramp issues related to Ramp features Code Impact - Low Minor code change that can safely applied to the codebase needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 9, 2022
blackdevelopa
blackdevelopa approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alaahd
alaahd approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wachunei wachunei merged commit cecdfc5 into main Aug 9, 2022
@wachunei wachunei deleted the fix/onramp-staging-redirect branch August 9, 2022 14:08
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
Code Impact - Low Minor code change that can safely applied to the codebase team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @alaahd @blackdevelopa