Refactor SendTransaction Component #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sethkfman
reviewed
Aug 11, 2022
sethkfman
reviewed
Aug 11, 2022
app/components/UI/TransactionReview/TransactionReviewEIP1559Update/index.tsx
Outdated
Show resolved
Hide resolved
sethkfman
reviewed
Aug 11, 2022
app/components/UI/TransactionReview/TransactionReviewEIP1559Update/index.tsx
Outdated
Show resolved
Hide resolved
sethkfman
reviewed
Aug 11, 2022
sethkfman
reviewed
Aug 11, 2022
sethkfman
reviewed
Aug 11, 2022
sethkfman
added
release-5.7.0
blackdevelopa
added
the
team-confirmations-secure-ux
blackdevelopa
force-pushed
the
refactor-updateTxns
branch
from
4f26475
to
2ccddff
Compare
blackdevelopa
force-pushed
the
refactor-updateTxns
branch
from
2ccddff
to
6918633
Compare
sethkfman
reviewed
Sep 13, 2022
sethkfman
added
release-5.9.0
needs-qa
sethkfman
added
Mobile QA board
and removed
team-confirmations-secure-ux
blackdevelopa
force-pushed
the
refactor-updateTxns
branch
from
6918633
to
53853f6
Compare
blackdevelopa
force-pushed
the
refactor-sendTxns
branch
from
cb50e7c
to
62752d2
Compare
blackdevelopa
force-pushed
the
refactor-updateTxns
branch
from
53853f6
to
825b222
Compare
blackdevelopa
force-pushed
the
refactor-sendTxns
branch
from
48bd3ff
to
2c30085
Compare
|
@blackdevelopa not able to send on Binance testnet. Getting JSON-RPC error... |
chrisleewilcox
added
QA'd - Issues Found
|
Send refactor looks good on the following testnets....
|
resolved. http://recordit.co/1ZkJUCgmb0 |
|
Send is good on BNB testnet now. |
chrisleewilcox
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is very similar code spread across 5 components. This PR removes the eip1559 gas polling logic away from the send flow (confirm screen). The TransactionReview and EditGasFee screens is able to calculate the gas transaction cost. This logic is abstracted away in the gas polling file. The changes in this PR shouldn't modify existing behaviour when QA'd.
Progresses
https://github.com/MetaMask/mobile-planning/issues/272
Screenshots/Recordings
Screen.Recording.2022-08-10.at.20.15.12.mov
Issue
Progresses https://github.com/metamask/mobile-planning/issues/269
Checklist