Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @testing-library/react-hooks dependency #4839

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Aug 11, 2022

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

This PR introduces the @testing-library/react-hooks package into the project to enable hooks testing.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added dependencies Pull requests that update a dependency file No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 11, 2022
@gantunesr gantunesr marked this pull request as ready for review August 11, 2022 17:16
@gantunesr gantunesr requested a review from a team as a code owner August 11, 2022 17:16
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added the release-5.6.0 PRs for v5.6.0 release label Aug 11, 2022
@gantunesr gantunesr merged commit b2235af into main Aug 11, 2022
@gantunesr gantunesr deleted the dependencies/react-hooks-testing-library branch August 11, 2022 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
@cortisiko cortisiko added release-5.7.0 PRs for release 5.7.0 and removed release-5.6.0 PRs for v5.6.0 release labels Aug 25, 2022
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.7.0 PRs for release 5.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants