Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change skip to payment method in on-ramp flow #4860

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Change skip to payment method in on-ramp flow #4860

merged 4 commits into from
Aug 23, 2022
+13 −9

Conversation

wachunei
Copy link
Member

Description

This screen changes the behavior of skipping screen after the Fiat On Ramp flow has started.

  • Previous behavior was to skip directly to Amount to Buy screen
  • New behavior is to skip to Payment Methods screen.

Screenshots/Recordings
Before:

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-08-15.at.11.59.05.mp4

After:

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-08-15.at.12.00.48.mp4

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.7.0 PRs for release 5.7.0 labels Aug 15, 2022
@wachunei wachunei requested a review from a team as a code owner August 15, 2022 17:04
alaahd
alaahd suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small comment!

app/constants/navigation/Routes.ts Outdated Show resolved Hide resolved
@alaahd
Copy link
Contributor

alaahd commented Aug 17, 2022

A great example of adding enough description on the PR using screen recordings. awesome!

@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 23, 2022
@wachunei wachunei merged commit 00d6aea into main Aug 23, 2022
@wachunei wachunei deleted the refactor/onramp-skip-region-only branch August 23, 2022 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.7.0 PRs for release 5.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wachunei @alaahd @gantunesr @cortisiko