Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ApprovalTransaction Component #4868

Merged
merged 17 commits into from
Oct 27, 2022
Merged

Refactor ApprovalTransaction Component #4868

merged 17 commits into from
Oct 27, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Aug 16, 2022 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

Screen.Recording.2022-08-16.at.14.44.39.mov

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa marked this pull request as ready for review August 23, 2022 05:50
@blackdevelopa blackdevelopa requested a review from a team as a code owner August 23, 2022 05:50
@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Aug 23, 2022
sethkfman
sethkfman approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added release-5.9.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Sep 27, 2022
@blackdevelopa blackdevelopa force-pushed the refactor-sendTxns branch 2 times, most recently from 48bd3ff to 2c30085 Compare October 10, 2022 13:09
Base automatically changed from refactor-sendTxns to main October 11, 2022 20:36
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 11, 2022
@blackdevelopa blackdevelopa changed the title Refactor ApproveTransaction Component Refactor ApprovalTransaction Component Oct 12, 2022
@blackdevelopa blackdevelopa force-pushed the refactor-approveTxns branch 2 times, most recently from 31c7c98 to 37f526e Compare October 14, 2022 00:32
@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Oct 15, 2022
chrisleewilcox
chrisleewilcox requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goerli, Fuji, Mumbai testnets all look good. I am having issues testing this with BNB testnet. Getting JSON-RPC error....
https://recordit.co/zn0ab4MQ4Y

@blackdevelopa
Copy link
Contributor Author

blackdevelopa commented Oct 25, 2022 •
edited

Goerli, Fuji, Mumbai testnets all look good. I am having issues testing this with BNB testnet. Getting JSON-RPC error.... https://recordit.co/zn0ab4MQ4Y

Hey Chris, thanks for this. Updated now

Network coverage: https://docs.google.com/spreadsheets/d/15hDtscWe9T-1eYgnE0mIB2zZ96ydwMxALXmI7QwTsvo/edit#gid=0

@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Oct 27, 2022
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 27, 2022
@chrisleewilcox chrisleewilcox merged commit 63e9aca into main Oct 27, 2022
@chrisleewilcox chrisleewilcox deleted the refactor-approveTxns branch October 27, 2022 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-5.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blackdevelopa @chrisleewilcox @sethkfman