Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decimals for on-ramp order details exchange rate #4869

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

wachunei
Copy link
Member

Description

This PR removes the decimals places when rendering exchange rates, this could lead to show "0" as the price per token.

Screenshots/Recordings

Before
Simulator Screen Shot - iPhone 11 Pro - 2022-08-16 at 10 05 30
After
Simulator Screen Shot - iPhone 11 Pro - 2022-08-16 at 10 05 38

@wachunei wachunei requested a review from a team as a code owner August 16, 2022 15:08
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.7.0 PRs for release 5.7.0 labels Aug 16, 2022
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 23, 2022
@wachunei wachunei merged commit c518718 into main Aug 23, 2022
@wachunei wachunei deleted the refactor/onramp-exchange-rate branch August 23, 2022 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.7.0 PRs for release 5.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants