Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Missing Block Explorer #4878

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
Fix a bug regarding missing block explorers for Testnets

2. What is the improvement/solution?
Add a new condition to check for Testnets

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

block-explorer-fix.mov

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/347#issuecomment-1215627383

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 17, 2022
@gantunesr gantunesr marked this pull request as ready for review August 17, 2022 12:30
@gantunesr gantunesr requested a review from a team as a code owner August 17, 2022 12:30
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 17, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox merged commit 610a236 into main Aug 17, 2022
@chrisleewilcox chrisleewilcox deleted the fix/missing-block-explorer branch August 17, 2022 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2022
@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants