Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Force upgrade] Automatic security checks settings #4897

Merged
merged 2 commits into from
Aug 24, 2022
Merged

[Force upgrade] Automatic security checks settings #4897

merged 2 commits into from
Aug 24, 2022

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Aug 23, 2022 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

  • we need a setting to enable/disable the automatic security checks as well as inform users that their IP will be sent to github
  • this change allows for that setting to persist in global state
    2. What is the improvement/solution?
  • add some state to the existing security redux store
  • add a toggle setting to settings/security
  • this check will default to on
  • this setting will only be visible in dev mode and will be hidden in release until we finish this following ticket

Screenshots/Recordings
Simulator Screen Shot - iPhone 13 Pro - 2022-08-23 at 15 24 47

Issue

Progresses #4812

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston marked this pull request as ready for review August 24, 2022 19:51
@owencraston owencraston requested a review from a team as a code owner August 24, 2022 19:51
@owencraston
Copy link
Contributor Author

I triggered some test builds to triple check that the __DEV__ check works

gantunesr
gantunesr reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just revert those changes before merging

android/app/build.gradle Outdated Show resolved Hide resolved
bitrise.yml Outdated Show resolved Hide resolved
ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@owencraston
Copy link
Contributor Author

Just downloaded the APK and verified that the setting does not show in production.

Screenshot_20220824-172228.png

gantunesr
gantunesr approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston owencraston merged commit 1491989 into main Aug 24, 2022
@owencraston owencraston deleted the force-upgrade-setting branch August 24, 2022 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2022
@owencraston owencraston added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Aug 24, 2022
@cortisiko cortisiko added the release-5.7.0 PRs for release 5.7.0 label Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.7.0 PRs for release 5.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@owencraston @gantunesr @cortisiko