Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update send flow #4905

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Update send flow #4905

merged 1 commit into from
Aug 25, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 24, 2022

Description

More more info

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.7.0 PRs for release 5.7.0 labels Aug 24, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as ready for review August 24, 2022 22:37
@Cal-L Cal-L requested a review from a team as a code owner August 24, 2022 22:37
@cortisiko cortisiko added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA in Progress QA has started on the feature. labels Aug 24, 2022
cortisiko
cortisiko approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is QA passed 🌮 🦖

@cortisiko cortisiko merged commit a0bb045 into main Aug 25, 2022
@cortisiko cortisiko deleted the fix/369-update-send-flow branch August 25, 2022 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.7.0 PRs for release 5.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cal-L @cortisiko @gantunesr