Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] useDeleteWallet hook #4942

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[TESTING] useDeleteWallet hook #4942

merged 1 commit into from
Sep 6, 2022

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Add unit tests to the hook useDeleteWallet

Screenshots/Recordings

Not applicable

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 5, 2022
@gantunesr gantunesr marked this pull request as ready for review September 5, 2022 23:00
@gantunesr gantunesr requested a review from a team as a code owner September 5, 2022 23:00
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Like the restructuring.

@gantunesr gantunesr added release-5.8.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 6, 2022
@gantunesr gantunesr merged commit 6d55667 into main Sep 6, 2022
@gantunesr gantunesr deleted the test/useDeleteWallet branch September 6, 2022 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants