Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps: Add copy for 0% fee in quotes info modal #4946

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Sep 6, 2022

Description

This PR changes a hardcoded value being shown when the swaps quote had 0% MetaMask fee.

Screenshots/Recordings

Before and After
Simulator Screen Shot - iPhone 11 Pro - 2022-09-06 at 13 27 29 » Simulator Screen Shot - iPhone 11 Pro - 2022-09-06 at 13 19 21

When the quote has a value it is correctly displayed:
Simulator Screen Shot - iPhone 11 Pro - 2022-09-06 at 13 19 00

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) swaps MetaSwaps issues release-5.8.0 labels Sep 6, 2022
@wachunei wachunei requested a review from a team as a code owner September 6, 2022 18:31
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 6, 2022
@wachunei wachunei merged commit 756993e into main Sep 6, 2022
@wachunei wachunei deleted the fix/swaps-info-quote-fee branch September 6, 2022 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking swaps MetaSwaps issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants