Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] WebView Origin Whitelist #4958

Merged
merged 2 commits into from
Sep 12, 2022
Merged

[FIX] WebView Origin Whitelist #4958

merged 2 commits into from
Sep 12, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Sep 8, 2022 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

Restrict WebView origen whitelist to https and http.

Screenshots/Recordings

Not applicable

Issue

Progresses Planning #382

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr marked this pull request as ready for review September 8, 2022 20:55
@gantunesr gantunesr requested a review from a team as a code owner September 8, 2022 20:55
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 8, 2022
sethkfman
sethkfman approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 8, 2022
@gantunesr gantunesr mentioned this pull request Sep 9, 2022
Merged
@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels Sep 12, 2022
@gantunesr gantunesr merged commit 44e4e7d into main Sep 12, 2022
@gantunesr gantunesr deleted the fix/webview-origin-whitelist branch September 12, 2022 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @sethkfman @blackdevelopa