Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Speedup/Cancel legacy transactions #4972

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Unable to Speedup/Cancel legacy transactions #4972

merged 3 commits into from
Sep 21, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Sep 12, 2022 •
edited

Description
Non-EIP1559 transactions breaks when a user tries to speed up transaction. This test was done using BNB network and also applies to Optimism.

Screenshots/Recordings
https://recordit.co/1sIbNiNrfA

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/380

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner September 12, 2022 16:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Sep 12, 2022
@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead Mobile QA board and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 12, 2022
gantunesr
gantunesr reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you’re already checking with an optional in that if statement, you can remove the optionals inside the if

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 13, 2022
gantunesr
gantunesr approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 15, 2022
@chrisleewilcox
Copy link
Contributor

Tested.....

Speed Up: PASS
Cancel: PASS

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 21, 2022
@chrisleewilcox chrisleewilcox merged commit cfb69a2 into main Sep 21, 2022
@chrisleewilcox chrisleewilcox deleted the bug/380-updateLegacyTxn branch September 21, 2022 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-5.8.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blackdevelopa @chrisleewilcox @gantunesr @sethkfman