Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-ramp: Add compact payment method selector #4980

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

wachunei
Copy link
Member

Description

This PR adds a compact version for the on-ramp payment method selectors. These compact versions are used in the modal selectors.

Screenshots/Recordings

Before - After
Simulator Screen Shot - iPhone 11 Pro - 2022-09-13 at 20 12 44 Simulator Screen Shot - iPhone 11 Pro - 2022-09-13 at 20 12 51

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.8.0 labels Sep 14, 2022
@wachunei wachunei requested a review from a team as a code owner September 14, 2022 01:18
@wachunei wachunei changed the title Add compact payment method On-ramp: Add compact payment method Sep 14, 2022
@wachunei wachunei changed the title On-ramp: Add compact payment method On-ramp: Add compact payment method selector Sep 14, 2022
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 14, 2022
@wachunei wachunei merged commit 9063082 into main Sep 14, 2022
@wachunei wachunei deleted the feature/onramp-compact-payment-methods branch September 14, 2022 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants