Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Vault corruption error log #5018

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[FIX] Vault corruption error log #5018

merged 1 commit into from
Sep 22, 2022

Conversation

gantunesr
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

The Logger has a bug when it comes to logging error which type if not Error. This result in a difficulty when trying to assess the number of error cases for the "Vault Corruption" issue.

2. What is the improvement/solution?

Pass an Error object to the Logger instead of a string.

Screenshots/Recordings

Not applicable
Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Low Minor code change that can safely applied to the codebase release-5.8.0 labels Sep 22, 2022
@gantunesr gantunesr marked this pull request as ready for review September 22, 2022 21:05
@gantunesr gantunesr requested a review from a team as a code owner September 22, 2022 21:05
owencraston
owencraston approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but the code looks good ✅

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 22, 2022
@gantunesr gantunesr merged commit 41c5c44 into main Sep 22, 2022
@gantunesr gantunesr deleted the fix/vault-corruption-log branch September 22, 2022 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
Code Impact - Low Minor code change that can safely applied to the codebase No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @owencraston