Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Update all "Ooops" error messages copy #5025

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[ENHANCEMENT] Update all "Ooops" error messages copy #5025

merged 1 commit into from
Sep 26, 2022

Conversation

gantunesr
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Update all "Ooops" error messages copy

Screenshots/Recordings

Not applicable

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr
Copy link
Member Author

Hi @coreyjanssen! Can I have your feedback in this PR?

@coreyjanssen
Copy link

Thanks @gantunesr! This looks good to me. Removing "Ooops" from all error messages is crucial.

@gantunesr gantunesr marked this pull request as ready for review September 26, 2022 21:13
@gantunesr gantunesr requested a review from a team as a code owner September 26, 2022 21:13
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 26, 2022
sethkfman
sethkfman approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.9.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 26, 2022
@gantunesr gantunesr merged commit 0066822 into main Sep 26, 2022
@gantunesr gantunesr deleted the fix/oops-copy branch September 26, 2022 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-5.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @coreyjanssen @sethkfman