Deprecate snake case from feature flags #5031
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @nikoferro, does this PR require feature QA? |
Hi @gantunesr , IMHO there isn't any special QA for this other than to check that swaps still get the "enabled" flag for mobile (which i have checked on my end). The camel case key that enables swaps, was already present on the feature flags endpoint response, so this should be a harmless change |
gantunesr
added
the
Spot Check on the Release Build
|
Sounds good @nikoferro. Can you comment again "I have read the CLA Document and I hereby sign the CLA"? Not sure why it's failing. After that I can merge the PR |
|
I have read the CLA Document and I hereby sign the CLA |
|
@gantunesr Ha! there it goes, i thought you needed to trigger this manually after the first failed check |
|
I did trigger it manually but it's not working for some reason I haven't looked into it yet haha but commenting for a 2nd time is a easy workaround |
|
During regression it's only necessary to verify that Swaps is still functional for the mobile app, is not necessary any other extra test case besides the regular ones @cortisiko @chrisleewilcox |
Description
This change deprecates the use of snake case keys on feature flags on swaps.
For this the swaps-api has been updated to return both snake case and camel case values.
Once this PR and a similar one on the extension are merged, snake case values can be safely removed from swaps api
Screenshots/Recordings
Issue
See MMS-255
Checklist