Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-Ramp: Fix autolock dispatch for apple pay #5035

Merged
merged 1 commit into from
Oct 4, 2022
Merged

On-Ramp: Fix autolock dispatch for apple pay #5035

merged 1 commit into from
Oct 4, 2022

Conversation

wachunei
Copy link
Member

Description
This PR fixes the autolocking feature when using apple pay.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.8.0 labels Sep 27, 2022
@wachunei wachunei requested a review from a team as a code owner September 27, 2022 17:48
owencraston
owencraston approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test to verify but the change seems reasonable based on yesterdays discussions on slack. ✅ 🚢

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2022
@cortisiko cortisiko added release-5.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed release-5.8.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 28, 2022
@cortisiko cortisiko merged commit 2eede88 into main Oct 4, 2022
@cortisiko cortisiko deleted the fix/onramp-apple-pay-locksreen branch October 4, 2022 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
release-5.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @owencraston @cortisiko