Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Contract Box component #5067

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Sep 29, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Screenshots/Recordings
Screenshot 2022-09-30 at 00 27 08
Screenshot 2022-09-30 at 00 27 23

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/metamask/metamask-planning/184

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa marked this pull request as ready for review September 29, 2022 23:30
@blackdevelopa blackdevelopa requested a review from a team as a code owner September 29, 2022 23:30
@blackdevelopa blackdevelopa self-assigned this Sep 29, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 29, 2022
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the component has not been fully standardised & reviewed by the Design System team then I would move it inside the component-temp folder

Nevermind the comment, it is already on the temp folder 👍

Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blackdevelopa blackdevelopa merged commit f678bbb into main Oct 4, 2022
@blackdevelopa blackdevelopa deleted the component/184-contract-box branch October 4, 2022 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants