Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5074 translations for permission system #5077

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Sep 30, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Update copy for Permission System translation

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

#5074

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.9.0 area-translation For Blendin translation. labels Sep 30, 2022
@Cal-L Cal-L requested a review from a team as a code owner September 30, 2022 01:37
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L merged commit d9756a3 into main Sep 30, 2022
@Cal-L Cal-L deleted the feature/5074-translations-for-permission-system branch September 30, 2022 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-translation For Blendin translation. No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants