[FIX] Network switch during QR scan in Send Flow #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
the
needs-dev-review
cortisiko
added
QA in Progress
cortisiko
added
QA Passed
cortisiko
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
This PR is QA passed. Test Scenarios covered in this PR:
- https://www.notion.so/QRScanner-feature-fa7c3023c080461884bd0026d69c3e1e
- Scanning QR codes for:
- keystone - on the wallet and send flow screens
- extension qr - on the wallet and send flow screens
- mobile qr same networks - on the wallet and send flow screens
- mobile qr different networks - on the wallet and send flow screens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
It was reported that the app fails to switch the network during a QR scan to transfer funds. This issue presents a misleading situation where the user is not in the correct network during the transfer
2. What is the improvement/solution?
Refactor the network switching logic and SendFlow screen to correct the faulty behaviour.
Screenshots/Recordings
RPReplay_Final1664558851.MP4
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/435
Checklist