Component: Custom Spending Cap #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
force-pushed
the
component/183-custom-spending
branch
from
792e758
to
fcd838a
Compare
sethkfman
added
needs-dev-review
blackdevelopa
force-pushed
the
component/183-custom-spending
branch
from
757dd2a
to
a410dd1
Compare
Cal-L
reviewed
Dec 13, 2022
Cal-L
reviewed
Dec 13, 2022
app/component-library/components-temp/CustomSpendCap/CustomSpendCap.types.ts
Show resolved
Hide resolved
Cal-L
requested changes
Dec 13, 2022
app/component-library/components-temp/CustomSpendCap/CustomSpendCap.constants.ts
Show resolved
Hide resolved
Cal-L
approved these changes
Dec 13, 2022
blackdevelopa
removed
No QA Needed/E2E Only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR is part of the UI improvements for setting transaction spend limit. There is no QA review required at this time as this code is still in its component definition.
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
[Image]
https://user-images.githubusercontent.com/10342624/182721189-32deedf9-3a3b-4046-8f4f-609f4c0da183.png
[Updated Video]
http://recordit.co/5hNgjN11Om
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses https://github.com/metamask/metamask-planning/issues/183
Checklist