Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no payment methods screen #5088

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Add no payment methods screen #5088

merged 5 commits into from
Nov 11, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 4, 2022

Description

This PR adds a UI for the edge case a region has no available payment methods so the user can reset the flow.

Screenshots/Recordings
simulator_screenshot_A8AC2678-27D7-423D-9605-CB9CE3D10F38

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.9.0 labels Oct 4, 2022
@wachunei wachunei marked this pull request as ready for review October 4, 2022 18:57
@wachunei wachunei requested a review from a team as a code owner October 4, 2022 18:57
@wachunei wachunei force-pushed the fix/onramp-no-payment-methods branch from ec8c7a6 to 97cb49c Compare November 10, 2022 10:02
@wachunei wachunei force-pushed the fix/onramp-no-payment-methods branch from 97cb49c to 49b38d8 Compare November 10, 2022 10:03
owencraston
owencraston approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this under the assumption that the requested changes will occur in future changes. It would be great to get some tests on these!

@wachunei wachunei merged commit 4cd929b into main Nov 11, 2022
@wachunei wachunei deleted the fix/onramp-no-payment-methods branch November 11, 2022 01:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.11.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @owencraston @cortisiko