Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit/50901 part 1 #5091

Merged
merged 15 commits into from
Oct 6, 2022
Merged

Audit/50901 part 1 #5091

merged 15 commits into from
Oct 6, 2022

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 4, 2022 •
edited

Description

  • Unionized Avatars and Buttons
  • Standardized Storybook Structure

Screenshots/Recordings
Screen Shot 2022-10-04 at 8 53 52 AM
Screen Shot 2022-10-04 at 8 53 34 AM

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 4, 2022
@brianacnguyen brianacnguyen self-assigned this Oct 4, 2022
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 4, 2022 22:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comments

index.js Outdated Show resolved Hide resolved
app/component-library/components/Toast/Toast.tsx Outdated Show resolved Hide resolved
app/component-library/components/Toast/Toast.tsx Outdated Show resolved Hide resolved
app/component-library/components/Tags/TagUrl/TagUrl.tsx Outdated Show resolved Hide resolved
app/component-library/components/Pickers/PickerNetwork/PickerNetwork.tsx Outdated Show resolved Hide resolved
app/component-library/components/Pickers/PickerAccount/PickerAccount.tsx Outdated Show resolved Hide resolved
app/component-library/components/Badges/Badge/foundation/BadgeBase/BadgeBase.stories.tsx Outdated Show resolved Hide resolved
app/component-library/components/Badges/Badge/variants/BadgeNetwork/BadgeNetwork.tsx Outdated Show resolved Hide resolved
@brianacnguyen brianacnguyen merged commit 38b2133 into main Oct 6, 2022
@brianacnguyen brianacnguyen deleted the audit/50901-part-1 branch October 6, 2022 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @Cal-L