Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Button Base Size issue #5167

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fixed Button Base Size issue #5167

merged 1 commit into from
Oct 28, 2022

Conversation

brianacnguyen
Copy link
Contributor

Description

  1. ButtonBase ButtonSize import needed to be updated to import from Button.types

@brianacnguyen brianacnguyen added type-bug Something isn't working needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 28, 2022
@brianacnguyen brianacnguyen self-assigned this Oct 28, 2022
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 28, 2022 04:11
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen mentioned this pull request Oct 28, 2022
Closed
@brianacnguyen brianacnguyen linked an issue Oct 28, 2022 that may be closed by this pull request
Using ButtonPrimary causes error #5166
Closed
@brianacnguyen brianacnguyen merged commit fc246c5 into main Oct 28, 2022
@brianacnguyen brianacnguyen deleted the fix/5166-button-base branch October 28, 2022 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using ButtonPrimary causes error
2 participants
@brianacnguyen @jpcloureiro