Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] ENS name being resolved correctly #5172

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

tommasini
Copy link
Contributor

Description
When the user had a slower internet connection and it was really quick to press the confirm button, the button would be enabled but the address would not be ready yet. Because of that we only proceeded to the next screen with the ENS.

Proposed Solution
Now we ensure that we have on that screen the address of the ens to go to the amount screen.

Technical
This was due to a delay in the component state on the validation function that happens on pressing the confirm button. This hotfix's a solution but it's better that we refactor some of the validation logic of it.

Test cases
If you can slow down your internet, this could be done on browser stack or with the Network Link Conditioner on macos
Case 1:
(Repeat this many times until it happens)

  • Try ti send some USDC
  • Write an ens on the address input of Send screen and try to hit Confirm as fast as you can (For me I needed to use the enter of the Keyboard)
  • Then write an amount on the amount screen
  • On confirm screen check if the address is 0x0000000 (if it is this address is incorrect)

Issue

Progresses #5128

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner October 28, 2022 18:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit bc8cf2c into release/5.9.1 Oct 28, 2022
@tommasini tommasini deleted the fix/ens-race-error branch October 28, 2022 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants