Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networks-flow appium feature file #5188

Merged
merged 17 commits into from
Nov 9, 2022
Merged

Networks-flow appium feature file #5188

merged 17 commits into from
Nov 9, 2022

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Nov 1, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Implemented Networks feature test file testing scenarios related to the Networks flow. It runs tests related to adding a network, removing a network and interacting with custom networks.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review comments....

wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
wdio/features/NetworkFlow.feature Outdated Show resolved Hide resolved
app/components/UI/Navbar/index.js Outdated Show resolved Hide resolved
app/components/UI/NavbarTitle/index.js Show resolved Hide resolved
app/components/UI/OnboardingWizard/Step4/index.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/network-flow.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/network-flow.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/network-flow.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/network-flow.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/network-flow.js Outdated Show resolved Hide resolved
@Andepande Andepande marked this pull request as ready for review November 7, 2022 00:57
@Andepande Andepande requested a review from a team as a code owner November 7, 2022 00:57
app/components/UI/NetworkInfo/index.tsx Show resolved Hide resolved
app/components/UI/NetworkList/index.js Show resolved Hide resolved
app/components/UI/OnboardingWizard/Step4/index.js Outdated Show resolved Hide resolved
app/components/UI/NetworkModal/index.tsx Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
app/components/Views/Settings/NetworksSettings/index.js Outdated Show resolved Hide resolved
app/components/Views/Settings/index.js Outdated Show resolved Hide resolved
wdio/features/helpers/Selectors.js Outdated Show resolved Hide resolved
wdio/features/testIDs/Components/NetworksModal.testIds.js Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments but in general I think we can trim down the amount of steps you have in your feature file. There is also a lint error with one of your changes. Please address.

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andepande Andepande dismissed cortisiko’s stale review November 8, 2022 10:41

Unable to be approved by reviewer

app/components/UI/DrawerView/index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andepande Andepande merged commit d939215 into main Nov 9, 2022
@Andepande Andepande deleted the e2e-NETWORK-FLOW-FEATURE branch November 9, 2022 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants