Support for ens on deeplink transactions

[tommasini]

Description
When reading a deep link with an ENS instead of an address, when it was an ERC20 token it was being resolved to the wrong address on the confirm screen. When it was eth, the transaction would not have a destination address to send the eth.

Proposed Solution
It is implementing support for deep link ERC20 and ETH transactions with ENS. When parsing the recipient from the deep link, we resolve it to an address if it is an ENS.

Screenshots/Recordings

• transactions with wrong ens and address (Alert message approved 🚀)
  https://recordit.co/rcLMaD4ek0

• transactions ERC20 with ENS and address
  https://recordit.co/wTglGApwEz

• transaction ETH with ENS and address
  https://recordit.co/2y3piAzfTe

• Small fix on UI of confirm screen

Bug	Solution

Test Cases
Use https://metamask.github.io/metamask-deeplinks/# to generate the deep links

Case1 (ERC20 tx):

• The ens resolve in the correct way
• Couldn't submit the transaction due to this issue

Case2: (ETH tx):

• The ens resolve in the correct way
• Transaction submitted with success

Case3: (with the wrong ens or wrong address):

• Should appear one alert saying the recipient is wrong (Alert message approved 🚀)

Code impact
Low - Will impact the Send component and the deep link (QR Code) transactions

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #5176

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[gantunesr]

LGTM. Just left a last question

[gantunesr]

LGTM. Sending it to QA

[plasmacorral]

Observed on Android 11 device (Samsung a515f) that if the deeplink is to an invalid ENS name (borangefox.eth), that the user is presented with a (seemingly) infinite spinning wheel.

deeplink tested:
https://metamask.app.link/send/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48@1/transfer?address=borangefox.eth&uint256=1e15

https://recordit.co/pzAAfjaMdS

[plasmacorral]

RE: Small fix on UI of confirm screen

I believe that we should leave the line spacing as-is rather than centering the address in the field. There is an issue in production that if the TO: address is saved as a contact that neither the saved name nor the ENS are presented above the resolved address, like it would if the ENS name was not stored as a contact and was instead entered via the keyboard into the TO: field.

I will open the production issue in another ticket.

[plasmacorral]

Validated patch and invalid address with ENS names, as well as dapp and payment deeplinks.