Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Swaps backend controls #5194

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

nikoferro
Copy link
Member

@nikoferro nikoferro commented Nov 3, 2022

Description

Adding additional platform specific backend controls to swaps.

Issue

See MMS-307

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Documentation for this change was added on swaps-api

@nikoferro nikoferro requested a review from a team as a code owner November 3, 2022 10:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nikoferro nikoferro changed the title Add more granular killswitches for swaps Updating Swaps backend controls Nov 3, 2022
@sethkfman
Copy link
Contributor

@nikoferro Is this feature flag coming from server metadata?

@sethkfman sethkfman added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.10.0 labels Nov 3, 2022
@nikoferro
Copy link
Member Author

@sethkfman yes exactly, we are updating the feature flags for mobile on the backend and this change is related to those updates

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
Copy link
Contributor

@nikoferro Do you have permission to merge this ticket into the repo?

@sethkfman sethkfman merged commit 0e50c07 into MetaMask:main Nov 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants