Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loading experience #5198

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Improve loading experience #5198

merged 2 commits into from
Nov 10, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 4, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

#459

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner November 4, 2022 01:04
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 7, 2022
NicholasEllul
NicholasEllul reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a regression test that will fail if the old behaviour ever comes back again?

app/components/Views/BrowserTab/index.js Show resolved Hide resolved
app/components/Views/BrowserTab/index.js Show resolved Hide resolved
app/components/Views/BrowserTab/index.js Show resolved Hide resolved
app/components/Views/BrowserTab/index.js Show resolved Hide resolved
@sethkfman sethkfman added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Nov 10, 2022
sethkfman
sethkfman approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adding the comment for the WebView patch. LGTM

@Cal-L
Copy link
Contributor Author

Cal-L commented Nov 10, 2022

Can we add a regression test that will fail if the old behaviour ever comes back again?

Tagging @chrisleewilcox @cortisiko since they'll be adding automation for regression tests in the near future

@Cal-L Cal-L merged commit c09dda2 into main Nov 10, 2022
@Cal-L Cal-L deleted the improvement/459-browser-loading-optimization branch November 10, 2022 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicholasEllul NicholasEllul NicholasEllul left review comments

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.11.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cal-L @sethkfman @NicholasEllul