Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: add payment method detail and disclaimer #5213

Merged
merged 1 commit into from
Nov 10, 2022
Merged

On-ramp: add payment method detail and disclaimer #5213

merged 1 commit into from
Nov 10, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 8, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR now renders payment methods details and disclaimer strings from the API instead of hardcoded.

Screenshots/Recordings

Non-disclosable

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.11.0 labels Nov 8, 2022
@wachunei wachunei requested a review from a team as a code owner November 8, 2022 16:25
gantunesr
gantunesr approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit b6a77b5 into main Nov 10, 2022
@wachunei wachunei deleted the feature/onramp-payment-details-disclaimer branch November 10, 2022 09:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.11.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @gantunesr