Improve deeplinks experience

[jpcloureiro]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add needs-qa label when dev review is completed
5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #460

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[NicholasEllul]

I love this approach of intercepting the request! Are we able to add any tests to catch regressions in this behaviour?

[andreahaku]

@jpcloureiro did you check how this change behaves with the app specific schemas like metamask://, dapp://, wc:// or ethereum://?

[jpcloureiro]

@jpcloureiro did you check how this change behaves with the app specific schemas like metamask://, dapp://, wc:// or ethereum://?

@andreahaku opening any of these schemas inside the webview will open the alert dialog. If the user presses allow, it will execute as before.

[jpcloureiro]

I've change the functionality so that we can have a set of whitelisted protocols that will be opened by the webview without an alert dialog.

Any other protocol will display an alert dialog with the message `This website has been blocked from automatically opening an external application'

[sethkfman]

One minor comment for a method rename but other than that it looks good.

[sethkfman]

LGTM

[sethkfman]

@jpcloureiro Can you add the scenarios you tested and update the lint errors?

[jpcloureiro]

@jpcloureiro sending this back your way!

Issue

On the webview error screen, when I tap the "return to home page" button I get:[TypeError: Invalid URL: home.metamask.io]. Furthermore, I am not taken back to the mm home page. see recording

To reproduce:

• open the browser
• enter an invalid URL. For example https://asfasfo.aox
• When the error screen appears
• tap on "return to home page". Notice the error.

@cortisiko pushed a fix. It should go back to mm home page now.

[cortisiko]

Fix looks good @jpcloureiro, This is QA passed! 🌮 🌮