Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to on-ramp-sdk@1.3.1: Wyre Apple Pay auth support and inAppBrowser hook #5220

Merged
merged 13 commits into from
Nov 22, 2022
Merged

Upgrade to on-ramp-sdk@1.3.1: Wyre Apple Pay auth support and inAppBrowser hook #5220

merged 13 commits into from
Nov 22, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 9, 2022 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR upgrades the on-ramp-sdk to version 1.3.1.
It adds support for Wyre Apple Pay authorizationUrl which is included in this SDK version.
A new hook for the inAppBrowser is added.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei changed the title Upgrade to on-ramp-sdk@1.3.1-beta.6 with Wyre Apple Pay auth support Upgrade to on-ramp-sdk@1.3.1-beta.7 with Wyre Apple Pay auth support Nov 9, 2022
@wachunei wachunei changed the title Upgrade to on-ramp-sdk@1.3.1-beta.7 with Wyre Apple Pay auth support Upgrade to on-ramp-sdk@1.3.1: Wyre Apple Pay auth support and inAppBrowser hook Nov 15, 2022
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.12.0 labels Nov 15, 2022
@wachunei wachunei marked this pull request as ready for review November 15, 2022 23:19
@wachunei wachunei requested a review from a team as a code owner November 15, 2022 23:19
@wachunei wachunei force-pushed the refactor/onramp-buy-actions-auth-url branch from 6001479 to ebdb9b1 Compare November 16, 2022 05:42
Cal-L
Cal-L approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2022
@wachunei wachunei added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2022
@wachunei wachunei merged commit c868ee2 into main Nov 22, 2022
@wachunei wachunei deleted the refactor/onramp-buy-actions-auth-url branch November 22, 2022 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.12.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Cal-L