Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPENDENCIES] Update Segment dependencies #5237

Merged
merged 2 commits into from
Nov 14, 2022
Merged

[DEPENDENCIES] Update Segment dependencies #5237

merged 2 commits into from
Nov 14, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 14, 2022 •
edited

Description

Update Segment dependencies,

  • @segment/analytics-react-native: 2.7.0 -> 2.9.1
  • @segment/sovran-react-native: 0.4.4 -> 0.4.5

Screenshots/Recordings

Not applicable

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/372

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 14, 2022
@gantunesr gantunesr marked this pull request as ready for review November 14, 2022 12:58
@gantunesr gantunesr requested a review from a team as a code owner November 14, 2022 12:59
Fatxx
Fatxx approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2022
@gantunesr gantunesr merged commit a403dea into main Nov 14, 2022
@gantunesr gantunesr deleted the update-segment-dependencies branch November 14, 2022 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @Fatxx