Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser experience #5238

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Improve browser experience #5238

merged 4 commits into from
Nov 29, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Nov 14, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses
#458
#354

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner November 14, 2022 14:51
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Nov 14, 2022
@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead q4 labels Nov 14, 2022
@blackdevelopa blackdevelopa mentioned this pull request Nov 14, 2022
3 tasks
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. You can ignore the areas where I commented that I tagged. It's just a way for me to identify the areas of code that changed. Btw, it looks like there are a bunch of changes that you didn't actually touch. If you have the chance, I'd recommend reapplying the changes that you made and then re-patching to see if you still get all of the diffs.

patches/react-native-webview+11.13.0.patch Outdated Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Outdated Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Outdated Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Show resolved Hide resolved
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 17, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 23, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cal-L @blackdevelopa @NicholasEllul This PR does what it was set out to do. I went ahead and did the browser regression and reported my findings here.

@cortisiko cortisiko added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Nov 24, 2022
@blackdevelopa
Copy link
Contributor Author

@cortisiko I have now updated the cirt app description here

@vpintorico vpintorico removed the QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed label Nov 29, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing the above with @blackdevelopa @NicholasEllul we decided that the above is not a blocker for this PR. We will follow up in a different PR. You can track the progress here

@cortisiko cortisiko added the QA Passed A successful QA run through has been done label Nov 29, 2022
@cortisiko cortisiko merged commit 10ed756 into main Nov 29, 2022
@cortisiko cortisiko deleted the patch/144-update branch November 29, 2022 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
q4 QA Passed A successful QA run through has been done release-5.12.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants