Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPDATE] Updates WebRTC and Socket.io client to the latest versions #5263

Merged
merged 9 commits into from
Nov 23, 2022
Merged

[UPDATE] Updates WebRTC and Socket.io client to the latest versions #5263

merged 9 commits into from
Nov 23, 2022

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Nov 17, 2022 •
edited

  • updates WebRTC to v1.106.1
  • updates Socket.io client to 4.5.3

Note: WebRTC v1.106.1 no longer requires to download the bitcode for iOS so this step has been removed from package.json and bitrise.yml

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku changed the title Updates WebRTC and Socket.io client to the latest versions [UPDATE] Updates WebRTC and Socket.io client to the latest versions Nov 18, 2022
@andreahaku andreahaku marked this pull request as ready for review November 21, 2022 11:09
@andreahaku andreahaku requested a review from a team as a code owner November 21, 2022 11:09
@andreahaku andreahaku added release-5.12.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 21, 2022
@andreahaku andreahaku self-assigned this Nov 21, 2022
Cal-L
Cal-L approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the comment regarding versions looks good, LGTM!

ios/Podfile Show resolved Hide resolved
bitrise.yml Show resolved Hide resolved
@andreahaku andreahaku added the Priority - High Task with high priority label Nov 23, 2022
Cal-L
Cal-L approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreahaku andreahaku added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 23, 2022
@andreahaku andreahaku merged commit 08a5c4e into main Nov 23, 2022
@andreahaku andreahaku deleted the fix/updates_webrtc_socketio branch November 23, 2022 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
@chrisleewilcox chrisleewilcox removed the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@andreahaku andreahaku

Labels
Priority - High Task with high priority release-5.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreahaku @Cal-L @chrisleewilcox