-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-ramp: Add order pending description in details view #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
added
blocked
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-ramp
issues related to Ramp features
Spot Check on the Release Build
If a ticket doesn't require feature QA, but does require some form of manual spot checking
release-5.12.0
labels
Nov 17, 2022
Base automatically changed from
refactor/onramp-buy-actions-auth-url
to
main
November 22, 2022 14:36
Cal-L
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cal-L
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-5.12.0
Spot Check on the Release Build
If a ticket doesn't require feature QA, but does require some form of manual spot checking
team-ramp
issues related to Ramp features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>⚠️ Rebase to main once refactor/onramp-buy-actions-auth-url
is mergedDevelopment & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR renders a description for a pending status in the order details view.
Screenshots/Recordings
non-disclosable
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses #???
Checklist