Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: allow amount formatting on android #5294

Merged
merged 2 commits into from
Nov 25, 2022
Merged

On-ramp: allow amount formatting on android #5294

merged 2 commits into from
Nov 25, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 25, 2022 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds a number format to Android in the Amount to Buy screen. This feature was present in iOS.

Screenshots/Recordings

Before - After
Screenshot_20221125_111507 Screenshot_20221125_111440

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.12.0 labels Nov 25, 2022
@wachunei wachunei marked this pull request as ready for review November 25, 2022 17:22
@wachunei wachunei requested a review from a team as a code owner November 25, 2022 17:22
gantunesr
gantunesr reviewed Nov 25, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a comment

app/components/UI/FiatOnRampAggregator/utils/index.ts Show resolved Hide resolved
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 25, 2022
@wachunei wachunei merged commit db811ad into main Nov 25, 2022
@wachunei wachunei deleted the feature/onramp-android-amount-format branch November 25, 2022 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa left review comments

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @gantunesr @blackdevelopa