Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Remove RPC URL metrics #5307

Merged
merged 3 commits into from
Dec 1, 2022
Merged

[IMPROVEMENT] Remove RPC URL metrics #5307

merged 3 commits into from
Dec 1, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 28, 2022 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

Stop logging the RPC URL in our metrics events

2. What is the improvement/solution?

Remove the relevant parameter from the following events,

  • Network Added
  • Network Switched
  • Network Requested
  • Network Request Rejected

Screenshots/Recordings

Not applicable

Issue

Progresses #5302

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr marked this pull request as ready for review November 28, 2022 19:31
@gantunesr gantunesr requested a review from a team as a code owner November 28, 2022 19:31
blackdevelopa
blackdevelopa reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only comment is about not removing blockExplorerUrl as well. Does it matter less?

app/components/UI/NetworkList/index.js Show resolved Hide resolved
app/components/UI/NetworkModal/index.tsx Show resolved Hide resolved
app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js Show resolved Hide resolved
app/core/RPCMethods/wallet_addEthereumChain.js Show resolved Hide resolved
app/core/RPCMethods/wallet_switchEthereumChain.js Outdated Show resolved Hide resolved
@gantunesr gantunesr mentioned this pull request Nov 28, 2022
Closed
3 tasks
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 28, 2022
blackdevelopa
blackdevelopa approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you, @gantunesr

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 28, 2022
@omnat omnat linked an issue Nov 28, 2022 that may be closed by this pull request
[PRIVACY] Metrics events or properties updates #5315
Closed
@gantunesr gantunesr merged commit 8d47108 into main Dec 1, 2022
@gantunesr gantunesr deleted the improvement/remove-rpc-url-metrics branch December 1, 2022 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-5.12.1 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PRIVACY] Metrics events or properties updates
3 participants
@gantunesr @blackdevelopa @sethkfman