Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Estimated gas fee calculation on the tx detail page #5318

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fix Estimated gas fee calculation on the tx detail page #5318

merged 2 commits into from
Nov 29, 2022

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 29, 2022 •
edited

Description

  • Fix Estimated gas fee calculation on the tx detail page for Swaps on EIP-1559 networks
  • Fix NAN ETH in Total amount if estimated gas fee is < 0.00001 ETH

Screenshots

Before:
image

After:
image

Before:
image

After:
image

@dan437 dan437 requested a review from a team as a code owner November 29, 2022 12:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.12.0 labels Nov 29, 2022
@gantunesr gantunesr merged commit 80979cf into MetaMask:main Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan437 @gantunesr