Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Force upgrade] only fetch minimum versions if permissions enabled #5333

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[Force upgrade] only fetch minimum versions if permissions enabled #5333

merged 1 commit into from
Dec 2, 2022

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Dec 1, 2022 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

  • I noticed that due to an oversight I made, we were making fetch calls to Github before the user granted persmission. Luckily this was not in production.
    2. What is the improvement/solution?
  • this is a small change that checks if this permission is given before making the fetch. If not we will not fetch and return a state of Error for the useAppConfig.
  • This fix patches a bug made in this original PR

Screenshots/Recordings

Screen.Recording.2022-12-01.at.1.54.58.PM.compressed.mov

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/505

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@owencraston owencraston requested a review from a team as a code owner December 1, 2022 21:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing release-5.12.1 labels Dec 1, 2022
gantunesr
gantunesr approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 1, 2022
sethkfman
sethkfman approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston owencraston changed the base branch from main to release/5.12.0 December 1, 2022 23:39
@owencraston owencraston force-pushed the fix/force-upgrade-call branch 2 times, most recently from e95ac4b to cd3dd5b Compare December 1, 2022 23:43
chrisleewilcox
chrisleewilcox approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit b5daadf into release/5.12.0 Dec 2, 2022
@chrisleewilcox chrisleewilcox deleted the fix/force-upgrade-call branch December 2, 2022 00:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@sethkfman sethkfman sethkfman approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.12.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@owencraston @chrisleewilcox @sethkfman @gantunesr