Align buttons with Figma #5343
Merged
Align buttons with Figma #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianacnguyen
added
the
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Hey @brianacnguyen, Can you please provide more details about what's being done here? Also if applicable add screenshots or screen recordings of the respective changes. |
Fatxx
previously requested changes
Jan 10, 2023
…to morph/align-buttons-5342
done |
Cal-L
approved these changes
Feb 4, 2023
app/component-library/components/Buttons/ButtonIcon/ButtonIcon.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/ButtonIcon/ButtonIcon.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/variants/ButtonSecondary/README.md
Show resolved
Hide resolved
...onent-library/components/Buttons/Button/variants/ButtonSecondary/ButtonSecondary.stories.tsx
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/variants/ButtonPrimary/README.md
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/variants/ButtonLink/ButtonLink.styles.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/variants/ButtonLink/ButtonLink.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/variants/ButtonLink/ButtonLink.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/foundation/ButtonBase/README.md
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/foundation/ButtonBase/ButtonBase.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Screenshots
Combine ButtonTertiary with ButtonLink
Add width options to buttons
Separate out ButtonIcon
Update Buttons to use isDanger
Add ButtonIcon Sizes
Issue
Progresses #???
Checklist