Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: remove old on-ramp experience #5351

Merged
merged 7 commits into from
Dec 21, 2022
Merged

On-ramp: remove old on-ramp experience #5351

merged 7 commits into from
Dec 21, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 5, 2022 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR removes old on-ramp experience code.

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.13.0 labels Dec 7, 2022
@wachunei wachunei marked this pull request as ready for review December 7, 2022 14:37
@wachunei wachunei requested a review from a team as a code owner December 7, 2022 14:37
@cortisiko cortisiko added needs-ramp-qa Tickets that need feature QA on the ramps flows and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 16, 2022
@wachunei wachunei added QA Passed A successful QA run through has been done needs-ramp-qa Tickets that need feature QA on the ramps flows and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Dec 20, 2022
owencraston
owencraston approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but the code looks good.

@wachunei wachunei merged commit 207d1ad into main Dec 21, 2022
@wachunei wachunei deleted the refactor/onramp-remove-old-experience branch December 21, 2022 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done release-5.13.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @owencraston @cortisiko