Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy for Opt in metrics screen and enable custom mainnet RPC #5362

Merged
merged 27 commits into from
Dec 8, 2022
Merged

Update copy for Opt in metrics screen and enable custom mainnet RPC #5362

merged 27 commits into from
Dec 8, 2022
+483 −177

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 7, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Old PR here #5334

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
#5301

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

cortisiko and others added 20 commits November 29, 2022 14:38
@cortisiko
add e2e coverage for automatic security update screen (#5291)
bbf3c38 
* add e2e coverage for automatic security update screen

* removed unncessary comment.

* fixing contract nickname test

* readd test

* fix test step
@Cal-L
Add network screen to onboarding stack
7722c15
@Cal-L
Update metametrics screen layout
13cfe0d
@Cal-L
Update metametrics copy
4bb0bd8
@Cal-L
Remove old privacy policy copies
029c5b6
@Cal-L
Begin handling isRPCUpdate prop in NetworkSettings
6b18b22
@Cal-L
Create editable default mainnet
5426bcd
@Cal-L
Fix RPC comparison
52efa0b
@Cal-L
Update ETH custom network name
9b77361
@Cal-L
Enforce scroll to end on metametrics screen
8606ec7
@cortisiko
e2e changes for metametrics screen
8e087a8
@Cal-L
Fix rpc type warning and invalid URL crasher
62174f9
@Cal-L
Fix updating network instead of duplicating
9583be3
@Cal-L
Fix duplicate rpc networks
65f7831
@Cal-L
Begin consolidating mainnet checks
953b5a8
@Cal-L
Revert "Remove old privacy policy copies"
555a143 
This reverts commit 029c5b6.
@Cal-L
Revert "Update metametrics copy"
94cbda7 
This reverts commit 4bb0bd8.
@Cal-L
Revert "Enforce scroll to end on metametrics screen"
cf77eb1 
This reverts commit 8606ec7.
@Cal-L
Revert "Update metametrics screen layout"
1dcea71 
This reverts commit 13cfe0d.
@Cal-L
Revert opt in to use old UI. Update copy. Hide NFT banner for non def…
d5d1393 
…ault mainnet
@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.12.1 labels Dec 7, 2022
@Cal-L Cal-L requested a review from a team as a code owner December 7, 2022 17:52
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L mentioned this pull request Dec 7, 2022
Closed
3 tasks
@Cal-L Cal-L added QA in Progress QA has started on the feature. Mobile QA board and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 7, 2022
@Cal-L Cal-L force-pushed the feature/5301-metametrics-copy-only branch from 64077da to 981cffb Compare December 7, 2022 20:42
sethkfman
sethkfman approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cortisiko
cortisiko approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is QA passed. Scenarios I covered:

On custom main nets (RPC urls that are not supported by infura)

  • the acceptance criteria here
  • Testing the SDK
  • Testing keystone transactions
  • sending ERC-20's, NFT's, ETH
  • sending to contract addresses
  • sending to ENS addresses
  • saving contacts and verifying that is appear on any custom mainnet

I also repeated the above on the infra-supported mainnet as well.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 8, 2022
@chrisleewilcox chrisleewilcox mentioned this pull request Dec 8, 2022
Closed
3 tasks
@Cal-L Cal-L merged commit b712653 into release/5.12.1 Dec 8, 2022
@Cal-L Cal-L deleted the feature/5301-metametrics-copy-only branch December 8, 2022 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cal-L @sethkfman @cortisiko @chrisleewilcox