Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp Refactor wyre authentication url approach #5366

Merged
merged 1 commit into from
Dec 8, 2022
Merged

On-ramp Refactor wyre authentication url approach #5366

merged 1 commit into from
Dec 8, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 7, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This PR changes the approach we use for Wyre's authentication URLs requirement for on-ramp orders.
Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei force-pushed the hotfix/onramp-wyre-auth branch 2 times, most recently from 7ad79aa to 9d2427a Compare December 8, 2022 00:06
@wachunei wachunei marked this pull request as ready for review December 8, 2022 00:06
@wachunei wachunei requested a review from a team as a code owner December 8, 2022 00:06
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei changed the base branch from main to release/5.12.1 December 8, 2022 00:11
@wachunei wachunei added QA Passed A successful QA run through has been done release-5.12.1 labels Dec 8, 2022
sethkfman
sethkfman approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit d496201 into release/5.12.1 Dec 8, 2022
@wachunei wachunei deleted the hotfix/onramp-wyre-auth branch December 8, 2022 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.12.1 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @sethkfman