Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jest expect type #5400

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix jest expect type #5400

merged 1 commit into from
Dec 15, 2022

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes expect type which was causing types issue.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei marked this pull request as ready for review December 15, 2022 16:32
@wachunei wachunei requested a review from a team as a code owner December 15, 2022 16:32
@wachunei wachunei changed the title Fix jest type Fix jest expect type Dec 15, 2022
Fatxx
Fatxx reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 15, 2022
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 15, 2022
@wachunei wachunei merged commit 41dc517 into main Dec 15, 2022
@wachunei wachunei deleted the fix/expect-type branch December 15, 2022 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Fatxx