Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Refactor "Screenshot Deterrent" for Android #5447

Merged
merged 4 commits into from
Jan 4, 2023
Merged

[IMPROVEMENT] Refactor "Screenshot Deterrent" for Android #5447

merged 4 commits into from
Jan 4, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jan 4, 2023 •
edited

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
Both solutions for "Screenshot Deterrent" on iOS and Android have some inconsistencies regarding the screens it's activated. This refactor aims to improve this issue.

2. What is the improvement/solution?
Refactor the hook useScreenshotDeterrent to include Android's "Prevent Screenshot" solution.

Screenshots/Recordings

Recording of Android behaviour after the refactor. The screen is black during screen share and/or recordings when it's displaying sensitive data (Android privacy feature).

android-recording.mov

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/227

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 4, 2023
@gantunesr gantunesr marked this pull request as ready for review January 4, 2023 04:03
@gantunesr gantunesr requested a review from a team as a code owner January 4, 2023 04:03
andreahaku
andreahaku approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 4, 2023
@gantunesr gantunesr merged commit ee4b651 into main Jan 4, 2023
@gantunesr gantunesr deleted the improvement/screenshot-deterrent-android branch January 4, 2023 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
release-5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @andreahaku