Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Use "ModalConfirmation" component for the QR Reader security alert #5453

Merged
merged 6 commits into from
Jan 5, 2023
Merged

[IMPROVEMENT] Use "ModalConfirmation" component for the QR Reader security alert #5453

merged 6 commits into from
Jan 5, 2023

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?

As part of the security improvements regarding the QR Reader, a new design for the warning modal is now available to use.

2. What is the improvement/solution?

Use the new ModalConfirmation component. See the following design.

Screenshots/Recordings

QR.reader.mov

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/312

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) design-review Any feature that needs feedback from the design team labels Jan 4, 2023
@holantonela
Copy link

holantonela commented Jan 4, 2023 •
edited

Review

  • Let's make sure the url has space to break in two or three lines so always remains visible.
  • Remove the white space before the paragraph starts.

Looks good for me! Removing design-qa label.

@holantonela holantonela removed the design-review Any feature that needs feedback from the design team label Jan 4, 2023
@gantunesr gantunesr marked this pull request as ready for review January 4, 2023 20:55
@gantunesr gantunesr requested a review from a team as a code owner January 4, 2023 20:55
@gantunesr
Copy link
Member Author

Changes according to @holantonela feedback,

Fatxx
Fatxx approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 5, 2023
@gantunesr gantunesr merged commit d62c1c9 into main Jan 5, 2023
@gantunesr gantunesr deleted the improvement/qr-code-alert branch January 5, 2023 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
release-5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @holantonela @Fatxx