Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sepolia network #5458

Merged
merged 27 commits into from
Apr 18, 2023
Merged

Support sepolia network #5458

merged 27 commits into from
Apr 18, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jan 6, 2023 •
edited

Description
Add support for sepolia network
This PR have merged in it this PR

Proposed Solution
Add support for sepolia network and remove code with rinkeby, ropsten and kovan
Also removed deprecated warning when the user was on the deprecated test networks.
Added and changed test cases with Sepolia Network.

Screenshots/Recordings
(Update Sepolia Icon on the last commit)
image

Test Cases
Case1:

  • Change to Sepolia Network
  • Tokens are fetched correctly
  • Go to send flow
  • Expected to be able to execute a transaction

Case2:

  • Change to Ethereum Mainnet
  • Tokens are fetched correctly
  • Go to send flow
  • Expected to be able to execute a transaction

Case3:

  • Change to Goerli Network
  • Tokens are fetched correctly
  • Go to send flow
  • Expected to be able to execute a transaction

Recordings

Case4:
Importing ERC20 token on Sepolia and sending transaction - https://recordit.co/2gNSkJ4cRY and https://recordit.co/6jF4tZckR2

Case5:
connect to the test dapp and perform dapp interactions.
Interactions include: Creating token, approving tokens and contracts (1155's, Multisig, collectibles) performing a multisig
transaction - https://recordit.co/DIq4Df9B7w

Case 6:
user should not have the ability to edit or delete the sepolia network - https://recordit.co/iMuUdMA9V6

Case 7:
the API keys for sepolia should not be exposed in the RPC URL endpoint.

Case 8:
Rinkeby, Ropsten and Koran should no longer be in on the networks page: Settings > networks.

Issue

Progresses #5406

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner January 6, 2023 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title Networks Support sepolia network Jan 6, 2023
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2023
blackdevelopa
blackdevelopa approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update. This looks good to me. 🙌🏾

@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 11, 2023
@tommasini tommasini mentioned this pull request Jan 12, 2023
Merged
2 tasks
@tommasini tommasini removed Mobile QA board needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 13, 2023
@Gudahtt
Update controllers to match core release v39
a874df8 
Most controller packages have been updated to the versions included in
the core monorepo v39 release. The keyring controller was the only
package held back, due to the BigInt incompatibility.

Most of the breaking changes are related to dropping support for
Ropsten, Rinkeby, and Kovan. The other breaking changes do not affect
mobile.
@Gudahtt
Update assets-controllers patch
924680e
@Gudahtt Gudahtt mentioned this pull request Apr 5, 2023
Closed
3 tasks
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 6, 2023
@socket-security
Copy link

socket-security bot commented Apr 6, 2023 •
edited

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@metamask/composable-controller@1.0.2 1.0.1...1.0.2 None +0/-1 metamaskbot
@metamask/address-book-controller@1.1.0 1.0.1...1.1.0 None +0/-1 metamaskbot
@metamask/network-controller@3.0.0 2.0.0...3.0.0 None +0/-1 metamaskbot
@metamask/gas-fee-controller@3.0.0 2.0.1...3.0.0 None +1/-2 metamaskbot
@metamask/message-manager@1.0.2 1.0.1...1.0.2 None +0/-1 metamaskbot
@metamask/transaction-controller@3.0.0 2.0.0...3.0.0 None +2/-2 metamaskbot
@metamask/approval-controller@1.1.0 1.0.1...1.1.0 None +0/-1 metamaskbot
@metamask/permission-controller@2.0.0 1.0.2...2.0.0 None +1/-2 metamaskbot
@metamask/assets-controllers@4.0.0 3.0.1...4.0.0 None +7/-2 metamaskbot

🚮 Removed packages: @metamask/base-controller@1.1.1

@Gudahtt Gudahtt mentioned this pull request Apr 6, 2023
Merged
3 tasks
@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 7, 2023
@Gudahtt
Copy link
Member

Gudahtt commented Apr 11, 2023

CI is failing due to an audit issue, but this was fixed on main so it should pass after the next update

@tommasini
Copy link
Contributor Author

This PR is no longer blocked since abi-utils was updated to support node 14

adonesky1
adonesky1 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hesterbruikman
Copy link
Contributor

Thanks @tommasini was looking out for this one!

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 18, 2023
cortisiko
cortisiko approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good 🌮 🌮

@cortisiko cortisiko merged commit 6781a12 into main Apr 18, 2023
13 checks passed
@cortisiko cortisiko deleted the implement/5406-sepolia-support branch April 18, 2023 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@cortisiko cortisiko cortisiko approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.5.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tommasini @Gudahtt @hesterbruikman @cortisiko @blackdevelopa @adonesky1 @gauthierpetetin